Save corpus continuously while fuzzing; add TestSimplified and ErrorEvent events; change event system #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samalws-tob
force-pushed
the
saveCoverageEarly4
branch
2 times, most recently
from
be5ca8a
to
bbf3f58
Compare
arcz
reviewed
May 18, 2023
samalws-tob
force-pushed
the
saveCoverageEarly4
branch
5 times, most recently
from
42b0ba0
to
c0e3206
Compare
samalws-tob
changed the title
arcz
reviewed
May 20, 2023
|
|
||
| -- mainly for handling events, but can be used for any purpose | ||
| -- `wait` is called on this group before echidna closes | ||
| , threadGroup :: ThreadGroup |
There was a problem hiding this comment.
We should move this to spawnListener and make all the handlers spawned async
There was a problem hiding this comment.
Not sure I understand what you mean here? I got rid of spawnListener, and all handlers are spawned async now
| @@ -127,6 +131,8 @@ main = withUtf8 $ withCP65001 $ do | |||
|
|
|||
| tests <- readIORef testsRef | |||
|
|
|||
| ThreadGroup.wait threadGroup | |||
There was a problem hiding this comment.
We should move this to spawnListener before putMVar stopVar ()
samalws-tob
force-pushed
the
saveCoverageEarly4
branch
3 times, most recently
from
8a2fca4
to
e3b86cd
Compare
samalws-tob
force-pushed
the
saveCoverageEarly4
branch
from
e3b86cd
to
a6faa99
Compare
|
Done in #1167. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
unsimplified-IORef [event -> IO ()]instead of channels. Channels were annoying because you would have to duplicate the channel and make a new thread for each event handlerspawnThreadandawaitThreadshelper functions to spawn temporary threads and wait for all threads to be finished (in this PR used to save files, so that the worker doesn't have to wait while the file is saved)-12345.txtfiles(Most of these changes are just solutions to problems I encountered while trying to make echidna save corpus while fuzzing)
Replaces #1047