Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #120

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Update README.md #120

merged 4 commits into from
Jul 13, 2023

Conversation

susan-garry
Copy link
Contributor

This addresses #114 (it turns out that our calyx installation instructions did need to be updated as a result of calyx renaming futil to calyx - sorry for the confusion Anshuman!) and the last two comments in #98.

What this PR does:

  • Clarify that our installation instructions assume that the user has installed calyx from source
  • Add a line about installing the calyx interpreter
  • Instruct users to configure stages.calyx.exec, rather than stages.futil.exec
  • Update instructions regarding the version of turnt that we're using

What this PR does NOT do:

  • Address the symlinked test files
  • Add a more precise invocation of fud check to only look at the tools a pollen user would need to get started
  • Address how to install and configure calyx via Docker or as a crate

Add instructions for installing the calyx interpreter, update the version of turnt that we are using.
@anshumanmohan
Copy link
Contributor

Thanks, looks good!

Copy link
Collaborator

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice catch on the erroneous fud config command!! Sorry for not noticing this, @anshumanmohan; I mis-diagnosed your issue. Looks good, modulo a capitalization suggestion.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Adrian Sampson <adrian@radbox.org>
@anshumanmohan anshumanmohan merged commit eec50ce into main Jul 13, 2023
1 check passed
@anshumanmohan anshumanmohan deleted the update-calyx-install-instrs branch July 13, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when generating a node depth accelerator using exine depth
3 participants