Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around rate limit #24

Merged
merged 8 commits into from
Feb 19, 2023
Merged

Work around rate limit #24

merged 8 commits into from
Feb 19, 2023

Conversation

cullenmcdermott
Copy link
Owner

@cullenmcdermott cullenmcdermott commented Dec 30, 2022

Fixes #23

Still a decent bit to do before merging.

  • Clean up fork for porkbun client and PR back to the original repo. I'll use my fork for the time being and then switch back to the original if they accept my PR
  • The number of retries should ideally be based off the number of resources we're trying to update. I'll look into the framework to see if that type of information is available during all the phases. If not then this will likely need to be configurable in the provider config
  • Testing

@cullenmcdermott
Copy link
Owner Author

Tests are definitely being messed up by the retries. I'm going to try switching to mockery. Also I talked to the TF Provider team and there's not an easy way for me to dynamically set the number of retries based on the number of resources being managed. So I'll do some testing later to see what a good number would be for a fairly large but hopefully still reasonable number of records, maybe 100?

@cullenmcdermott cullenmcdermott marked this pull request as ready for review February 19, 2023 01:04
@cullenmcdermott
Copy link
Owner Author

I didn't fix the testing like I'd hoped but I want to make some other updates before I refactor the testing too much.

@cullenmcdermott cullenmcdermott merged commit 8ef106f into main Feb 19, 2023
@cullenmcdermott cullenmcdermott deleted the workaround-rate-limits branch February 19, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues due poor requests limits in Porkbun API
1 participant