Update to React 16 #6
Conversation
The previous release came just before React 16. This actually updates react to version 16 in the dev dependencies, and updates other libraries that have been bumped to support react 16. The requestAnimationFrame global polyfill is to avoid errors when running the tests. Adds package-lock.json to the gitignore to avoid confusion.
| @@ -27,6 +27,7 @@ describe('SignalProvider', () => { | |||
| const c = shallow(<SignalProvider features={features}><div/></SignalProvider>); | |||
| expect(c.find('div').length).toBe(0); | |||
| c.instance().updateSignals({showStuff: true}); | |||
| c.update(); | |||
There was a problem hiding this comment.
So this was the trick to handle the async behavior? Wow.
There was a problem hiding this comment.
Enzyme is allowing the object reference to get out of sync with the actual state of the object under test. This update method gets the props, dom structure, etc back in line with the current state of the originally referenced instance. I was under the impression that enzyme was going to be updated to allow us to get by without adding these but they are not.
|
This PR is open and inactive for 30 days. Merging PRs open for a long time is error-prone. Please proceed to merging or make a comment to keep it open. You can also prevent PRs from being tagged stale ot closed with 'keep-open' tag. If there is no activity in 90 days, this PR will be closed |
|
This PR was closed because it has been inactive for 90 days since being marked as stale. |
The previous release came just before React 16. This actually updates react to version 16 in the dev dependencies, and updates other libraries that have been bumped to support react 16.
The requestAnimationFrame global polyfill is to avoid errors when running the tests.
Also adds package-lock.json to the gitignore to avoid confusion.