Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync with up-up-stream #4

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ commands below:
aws iam create-role \
--role-name jenkins-default \
--assume-role-policy-document \
'{"Version":"2012-10-17 ","Statement":[{"Effect": "Allow","Principal":{"Service":"codebuild.amazonaws.com"},"Action":"sts:AssumeRole"}]}'
'{"Version":"2012-10-17","Statement":[{"Effect": "Allow","Principal":{"Service":"codebuild.amazonaws.com"},"Action":"sts:AssumeRole"}]}'

# Create the project named "jenkins-cluster" using our service role
aws codebuild create-project \
Expand Down
10 changes: 5 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>plugin</artifactId>
<version>3.25</version>
<version>3.43</version>
<relativePath />
</parent>

Expand Down Expand Up @@ -46,24 +46,24 @@
<repositories>
<repository>
<id>repo.jenkins-ci.org</id>
<url>http://repo.jenkins-ci.org/public/</url>
<url>https://repo.jenkins-ci.org/public/</url>
</repository>
</repositories>
<pluginRepositories>
<pluginRepository>
<id>repo.jenkins-ci.org</id>
<url>http://repo.jenkins-ci.org/public/</url>
<url>https://repo.jenkins-ci.org/public/</url>
</pluginRepository>
</pluginRepositories>

<distributionManagement>
<repository>
<id>repo.jenkins-ci.org</id>
<url>http://repo.jenkins-ci.org/releases/</url>
<url>https://repo.jenkins-ci.org/releases/</url>
</repository>
<snapshotRepository>
<id>repo.jenkins-ci.org</id>
<url>http://repo.jenkins-ci.org/snapshots</url>
<url>https://repo.jenkins-ci.org/snapshots</url>
</snapshotRepository>
</distributionManagement>

Expand Down
27 changes: 27 additions & 0 deletions src/main/java/dev/lsegal/jenkins/codebuilder/CodeBuilderCloud.java
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
public class CodeBuilderCloud extends Cloud {
private static final Logger LOGGER = LoggerFactory.getLogger(CodeBuilderCloud.class);
private static final String DEFAULT_JNLP_IMAGE = "lsegal/jnlp-docker-agent:alpine";
private static final String DEFAULT_JNLP_COMMAND = "jenkins-agent";
private static final int DEFAULT_AGENT_TIMEOUT = 120;
private static final String DEFAULT_COMPUTE_TYPE = "BUILD_GENERAL1_SMALL";
private static final boolean DEFAULT_TERMINATE_AGENT = true;
Expand All @@ -78,6 +79,7 @@ public class CodeBuilderCloud extends Cloud {
private String computeType;
private String jenkinsUrl;
private String jnlpImage;
private String jnlpCommand;
private int agentTimeout;
private boolean terminateAgent;

Expand Down Expand Up @@ -219,6 +221,27 @@ public void setJenkinsUrl(String jenkinsUrl) {
this.jenkinsUrl = jenkinsUrl;
}

/**
* Getter for the field <code>jnlpCommand</code>.
*
* @return a {@link String} object.
*/
@Nonnull
public String getJnlpCommand() {
return StringUtils.isBlank(jnlpCommand) ? DEFAULT_JNLP_COMMAND : jnlpCommand;
}

/**
* Setter for the field <code>jnlpCommand</code>.
*
* @param jnlpCommand a {@link String} object.
*/
@DataBoundSetter
public void setJnlpCommand(String jnlpCommand) {
this.jnlpCommand = jnlpCommand;
}


/**
* Getter for the field <code>jnlpImage</code>.
*
Expand Down Expand Up @@ -419,6 +442,10 @@ public String getDefaultJnlpImage() {
return DEFAULT_JNLP_IMAGE;
}

public String getDefaultJnlpCommand() {
return DEFAULT_JNLP_COMMAND;
}

public int getDefaultAgentTimeout() {
return DEFAULT_AGENT_TIMEOUT;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
<f:textbox default="${descriptor.defaultJnlpImage}" />
</f:entry>

<f:entry field="jnlpCommand" title="${%JNLP Docker Image Command}">
<f:textbox default="${descriptor.defaultJnlpCommand}" />
</f:entry>

<f:entry field="agentTimeout" title="${%Agent Connection Timeout}">
<f:number default="${descriptor.defaultAgentTimeout}" />
</f:entry>
Expand Down