Add the initial destruction of cookbooks out of basic retention #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentm5
force-pushed
the
bm-add-retention-of-cookbook
branch
from
dbf0439
to
7df1b58
Compare
|
@jonathanmorley care to take a look? Would like some feedback on how we can get this to the same place our other package retention policies run. |
|
|
||
| def version_info_for_cookbook(cookbook_name) | ||
| nodes = all_nodes_for_cookbook(cookbook_name) | ||
| versions = Chef::CookbookVersion.available_versions(cookbook_name).map! do |version| |
There was a problem hiding this comment.
This is what happens when you refactor and miss something
|
|
||
| def version_info_for_cookbook(cookbook_name) | ||
| nodes = all_nodes_for_cookbook(cookbook_name) | ||
| versions = Chef::CookbookVersion.available_versions(cookbook_name).map! do |version| |
There was a problem hiding this comment.
No need to assign to unused variable
brentm5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to remove cookbooks that are not being used. It essentially does the following:
Things to consider.