Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Rework #11

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

Major Rework #11

wants to merge 21 commits into from

Conversation

kaiser-chris
Copy link

@kaiser-chris kaiser-chris commented Aug 19, 2024

Hi,

this is a major rework of the CWT files.

Some caveats:

Regards,

Chris

EDIT: Rewrote Pull Request description to clarify some caveats with my changes.

@tboby
Copy link
Member

tboby commented Aug 19, 2024

@kaiser-chris Up to you! Larger requests means you don't have to try and get my or @CaesarVincens attention as frequently :)

Do ping me if something is ready and I haven't merged it in a while.

@tboby
Copy link
Member

tboby commented Aug 19, 2024

There's a draft mode you could put it in so that others can still see it exists

@kaiser-chris kaiser-chris marked this pull request as draft August 19, 2024 09:39
@kaiser-chris
Copy link
Author

kaiser-chris commented Aug 19, 2024

Set to draft mode

@CaesarVincens
Copy link
Collaborator

Many thanks for putting all this work in! I had started a bit on Vic3 back in '22, but never got much done. I'll see about putting my stuff up online in case any of it helps you.

@CaesarVincens
Copy link
Collaborator

Many thanks for putting all this work in! I had started a bit on Vic3 back in '22, but never got much done. I'll see about putting my stuff up online in case any of it helps you.

Now that I look back at it, I may have already merged in all my work. Well, a good chance to check again.

@kaiser-chris kaiser-chris changed the title Added production_method_group, era and technology Major Rework Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants