Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the cypress/factory image #812

Merged
merged 151 commits into from
Jan 17, 2023
Merged

Introduce the cypress/factory image #812

merged 151 commits into from
Jan 17, 2023

Conversation

mjhenkes
Copy link
Member

@mjhenkes mjhenkes commented Jan 6, 2023

Closes #810

This PR introduces a cypress/factory image that can be used to generate a docker container with various combinations of the following.

  • node
  • yarn
  • chrome
  • firefox
  • edge
  • cypress

The factory docker container is also now used to generate cypress/base, cypress/browsers and cypress/included.

See the readme for more details.

On merge to master this should push the new factory image, a new version of included and browsers, but not a new included image (until we update the node version)

factory/README.md Outdated Show resolved Hide resolved
factory/README.md Outdated Show resolved Hide resolved
@@ -0,0 +1,5 @@
#! /bin/bash

# TODO: should typescript be versioned? Should it have it's own ARG for the factory?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suspect users may want more control over this, so passing in an optional ARG could be useful. This is anecdotal however. We could hold off until the issue arises.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was kind of my thought too.

Co-authored-by: Paul Jaffre <jaffrepaul@gmail.com>
@jaffrepaul
Copy link
Contributor

jaffrepaul commented Jan 13, 2023

I didn't have the time to give this a test run myself (esp given the additional, personal setup), but I gave it a good review.
I'm looking at your sample Circle runs, too many args caught my eye and was curious what the implications are.

Otherwise, great stuff @mjhenkes. This is big.

@mjhenkes
Copy link
Member Author

@jaffrepaul

I'm looking at your sample Circle runs, too many args caught my eye and was curious what the implications are.

Nice catch! the check was failing but circle wasn't warning me. Should be fixed now.

@jordanpowell88
Copy link
Contributor

jordanpowell88 commented Jan 14, 2023

@mjhenkes

I understand that users won't need to do this anymore but there are still use cases where we need to publish new images. I was really referring to those instances. Not a show stopper by any means but just figured it was worth noting this change for historical purposes nonetheless

factory/README.md Outdated Show resolved Hide resolved
factory/README.md Outdated Show resolved Hide resolved
factory/README.md Outdated Show resolved Hide resolved
factory/installScripts/cypress/default.sh Show resolved Hide resolved
@mjhenkes mjhenkes merged commit 4b2ebca into master Jan 17, 2023
@mjhenkes mjhenkes deleted the matth/docker-factory branch January 17, 2023 16:56
@Joelasaur
Copy link

This is the best feature I've never known I've needed, thank you so much for adding this. Incredibly helpful to the developer experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Docker Factory
6 participants