-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the cypress/factory image #812
Conversation
@@ -0,0 +1,5 @@ | |||
#! /bin/bash | |||
|
|||
# TODO: should typescript be versioned? Should it have it's own ARG for the factory? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suspect users may want more control over this, so passing in an optional ARG could be useful. This is anecdotal however. We could hold off until the issue arises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that was kind of my thought too.
Co-authored-by: Paul Jaffre <jaffrepaul@gmail.com>
I didn't have the time to give this a test run myself (esp given the additional, personal setup), but I gave it a good review. Otherwise, great stuff @mjhenkes. This is big. |
Nice catch! the check was failing but circle wasn't warning me. Should be fixed now. |
I understand that users won't need to do this anymore but there are still use cases where we need to publish new images. I was really referring to those instances. Not a show stopper by any means but just figured it was worth noting this change for historical purposes nonetheless |
This is the best feature I've never known I've needed, thank you so much for adding this. Incredibly helpful to the developer experience. |
Closes #810
This PR introduces a
cypress/factory
image that can be used to generate a docker container with various combinations of the following.The factory docker container is also now used to generate
cypress/base
,cypress/browsers
andcypress/included
.See the readme for more details.
On merge to master this should push the new factory image, a new version of included and browsers, but not a new included image (until we update the node version)