Skip to content

Commit

Permalink
feat: Implement correct behavior for all input types supporting arrow…
Browse files Browse the repository at this point in the history
… up (stepUp) and arrow down (stepDown) (#29678)

* Add changelog entry

* Update check in "_moveCursorUpOrDown" to trigger "stepUp" and "stepDown" on supported input types

* Update "validateTyping" function to validate {upArrow} and {downArrow} arguments for cy.type() for input[type=date]

* Remove "datetime" entry from valid input types

* Update chars validation for inputs that support "stepUp" and "stepDown"

* Add missing input types to dom.html

* Add tests of {upArrow} and {downArrow} for all supporting input types

* Update CHANGELOG

* Fix CHANGELOG line position

* Fix link to issue in CHANGELOG entry

* Fix typo in CHANGELOG

* Fix typo in CHANGELOG entry

* Merge develop

* Update changelog

* Add assertions for {upArrow} and {downArrow} arguments of cy.type() action that check if "change" and "input" events are triggered

* Fix changelog to include ref to issue

* Update packages/driver/cypress/e2e/commands/actions/type.cy.js

* update changelog

* Actually this is a feature release

* Fix test cases that fail on CI environment.

* Fix failing test case in type.cy.js test suite

* Refactor 'type.cy.js' test suite to skip tests for input type "month" and "week" for Webkit and Firefox browsers due to missing support

* add new release to changelog

* Prevent tests for input[type=range] from running on webkit browsers

* Update changelog

* Fix changelog

* Suppress tests for certain types of input when running on Webkit browsers

* Update use of check of webkit browser for consistency

* Update packages/driver/cypress/e2e/commands/actions/type.cy.js

* Update packages/driver/cypress/e2e/commands/actions/type.cy.js

* Update packages/driver/cypress/e2e/commands/actions/type.cy.js

* Update packages/driver/cypress/e2e/commands/actions/type.cy.js

* Update cli/CHANGELOG.md

Fix typo in CHANGELOG header

Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>

---------

Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
  • Loading branch information
4 people committed Aug 23, 2024
1 parent d4dc2f8 commit 06acc2e
Show file tree
Hide file tree
Showing 5 changed files with 360 additions and 56 deletions.
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ _Released 8/27/2024 (PENDING)_
- Added new
[`experimentalJustInTimeCompile`](/guides/references/experiments#Configuration)
configuration option for component testing. This option will only compile resources directly related to your spec, compiling them 'just-in-time' before spec execution. This should result in improved memory management and performance for component tests in `cypress open` and `cypress run` modes, in particular for large component testing suites. [`experimentalJustInTimeCompile`](/guides/references/experiments#Configuration) is currently supported for [`webpack`](https://www.npmjs.com/package/webpack) and [`vite`](https://www.npmjs.com/package/vite). Addresses [#29244](https://github.com/cypress-io/cypress/issues/29244).
- `.type({upArrow})` and `.type({downArrow})` now also works for date, month, week, time, datetime-local and range input types. Addresses [#29665](https://github.com/cypress-io/cypress/issues/29665).
- Added a `CYPRESS_SKIP_VERIFY` flag to enable suppressing Cypress verification checks. Addresses [#22243](https://github.com/cypress-io/cypress/issues/22243).
- Updated the protocol to allow making Cloud API requests. Addressed in [#30066](https://github.com/cypress-io/cypress/pull/30066).

Expand Down
Loading

4 comments on commit 06acc2e

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 06acc2e Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.0/linux-x64/develop-06acc2e8d214f563813b56e017949fd1f3a3d040/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 06acc2e Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.0/linux-arm64/develop-06acc2e8d214f563813b56e017949fd1f3a3d040/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 06acc2e Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.0/win32-x64/develop-06acc2e8d214f563813b56e017949fd1f3a3d040/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 06acc2e Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.0/darwin-x64/develop-06acc2e8d214f563813b56e017949fd1f3a3d040/cypress.tgz

Please sign in to comment.