-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: retain original array after defaultsDeep #27240 #27312
Conversation
8 flaky tests on run #54622 ↗︎
Details:
e2e/origin/basic_login.cy.ts • 1 flaky test • 5x-driver-firefox
|
@NiharPhansalkar #27240 kept failing - I made a new branch and it passes fine, I am not sure why. I've seen this happen before -- some CI weirdness. Can you approve this? I left an approval on your original PR, but had to remake it. You'll still get credit, your commits are here. |
Sure will approve! |
This PR has not had any activity in 180 days. If no activity is detected in the next 14 days, this PR will be closed. |
packages/app/cypress/e2e/subscriptions/specChange-subscription.cy.ts
Outdated
Show resolved
Hide resolved
2b3995e
to
7b8dc96
Compare
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
specPattern
doesn't yield error ifspecPattern
was originally an array #27103note remaking - original PR #27312 got stuck on red on CI, I could not get it to pass. New branch is fine 🤷
Additional details
What is affected by this change?
Previously the defaultsDeep function was merging/combining arrays. This PR will fix that issue and restore any arrays modified by the
setupNodeEvents
function.Steps to test
To test, copy the cypress.config.js from the
reproduction
section of the issue and configure for e2e testing. Then run cypress usingyarn cypress open --dev --config-file cypress.config.js
. After setting any key within the config object to any array value (within the setupNodeEvents function), it should reflect as is in the final config.How has the user experience changed?
User will get the exact config they supply in the
setupNodeEvents
function.PR Tasks
cypress-documentation
?type definitions
?