chore: update electron notary tool to v2 #27380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing will stop working November 23 and this allows us to get ahead of the curve. see electron/notarize@bf23272. Also inquirer types were having issues in build which updated from v7 to v8. Nothing major changed there except dropping node 10 support chore: add Team ID to mac os code sign as it is now needed by the new signing tool. see https://github.com/electron/notarize#notes-on-your-teamid. [run ci]
Passing run #49158 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
nagash77
approved these changes
Jul 25, 2023
mjhenkes
approved these changes
Jul 25, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Updates the
electron-notarizetool fromv1tov2which goes from thelegacynotary tool (which will be unsupported and will not work starting 11/23) to the newnotarytool. I upgraded this on a branch, which ran on the macstadium box and it looks to not be able to usev1any longer (not sure why). I figured the quickest solution is to just bump the notary tool 😅 .FWIW the new notary tool is supposed to be 10x faster as described in the repo. To use the new
notarytool, theteamIdproperty is needed, which has been correctly added to the circle context.Steps to test
Check to make sure
darwin_x64anddarwin_arm64jobs in circle are green and passing and notarization works when building the binaryHow has the user experience changed?
PR Tasks
cypress-documentation?type definitions?