Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: protocol/mount before async #27511

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

lmiller1990
Copy link
Contributor

Reworking a troublesome test.

@lmiller1990 lmiller1990 changed the base branch from dkasper/protocol/mount-before-async to release/13.0.0 August 10, 2023 01:19
@cypress
Copy link

cypress bot commented Aug 10, 2023

8 flaky tests on run #49684 ↗︎

0 5329 77 0 Flakiness 8

Details:

rejigger component and test
Project: cypress Commit: fc25a21264
Status: Passed Duration: 17:03 💡
Started: Aug 10, 2023 2:32 AM Ended: Aug 10, 2023 2:49 AM
Flakiness  patches.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
src/cross-origin/patches > submit > correctly submits a form when the target is _top for HTMLFormElement Test Replay Output
Flakiness  dependencies.cy.jsx • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin dependencies - jsx > works with a jsx file Test Replay Output
Flakiness  commands/assertions.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin assertions > .should() and .and() Test Replay Output
Flakiness  commands/aliasing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin aliasing > .as() > supports dom elements inside origin Test Replay Output
Flakiness  commands/network_requests.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin network requests > .request() to secondary origin Test Replay Output

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ryanthemanuel
Copy link
Collaborator

Thanks @lmiller1990!

@ryanthemanuel ryanthemanuel merged commit d27e249 into release/13.0.0 Aug 10, 2023
81 of 84 checks passed
@ryanthemanuel ryanthemanuel deleted the lmiller/protocol/mount-before-async branch August 10, 2023 13:44
@cypress cypress bot mentioned this pull request Aug 10, 2023
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants