fix: move main tab activation to puppeteer plugin #28898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
force-pushed
the
cacie/fix/main-tab-reactivation-hang
branch
from
7f32980
to
f6fc4f0
Compare
8 flaky tests on run #54067 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Screenshots
|
|
e2e/origin/basic_login.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Multi-step Auth > final auth redirects back to approval page - flat |
| |||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Launchpad: Open Mode > request for Cypress manifest > does not include `x-dependencies` header, if this is not the initial launch of Cypress |
Test Replay
Screenshots
|
|
global-mode.cy.ts • 1 flaky test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| ... > can be opened |
Test Replay
Screenshots
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.
Review all test suite changes for PR #28898 ↗︎
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
AtofStryker
reviewed
Feb 15, 2024
| } | ||
|
|
||
| window.addEventListener('message', onMessage) | ||
| window.postMessage({ message: 'cypress:extension:activate:main:tab' }) |
There was a problem hiding this comment.
whats the difference between cypress:extension:main:tab:activated and cypress:extension:activate:main:tab?
There was a problem hiding this comment.
cypress:extension:activate:main:tab is sent to the extension to tell it to activate the main tab. cypress:extension:main:tab:activated is the ack that the main tab was successfully activated.
chrisbreiding
approved these changes
Feb 15, 2024
AtofStryker
approved these changes
Feb 16, 2024
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Previously, we were attempting to activate the main tab before and after every command. This required the Chrome extension to be loaded and enabled, and was only useful for users who were leveraging the Puppeteer plugin. If the extension was disabled or disallowed by policy, commands would cause the runner to hang even when the Puppeteer plugin was not in use.
This PR moves tab closing behavior into the Puppeteer plugin itself, and adds some support logic to the driver and extension in order to accommodate the logic happening in a Cypress plugin rather than in the browser.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?