fix: do not use unload events in Chromium from App Runner

[cacieprins]

• Closes [Cypress 13.13.1, Chrome] - unload is not allowed #29880

Additional details

At the point when the Runner's EventManager adds global event listeners, setup() has yet to be called, so there is not an instance of Cypress to use for the browser family check. To fix, getRunnerConfigFromWindow() is extracted into its own file so it can be imported by both src/runner/index.ts and src/runner/event-manager.ts without causing a circular dependency.

Steps to test

Run a simple test in open mode with the following Cypress config:

module.exports = {
  e2e: {
    setupNodeEvents(on, config) {
      on('before:browser:launch', (_, launchOptions) => {
        launchOptions.args.push('--enable-features=DeprecateUnload')

        return launchOptions
      })
      return config
    },
  },
}

Observe that there are no warnings in the browser console about a disallowed unload event.

This behavior cannot be tested with Cy in Cy tests, as far as I can tell, and there are no unit tests for app, so this fix is currently only manually tested.

How has the user experience changed?

PR Tasks

• [NA] Have tests been added/updated?
• [NA] Has a PR for user-facing changes been opened in cypress-documentation?
• [NA] Have API changes been updated in the type definitions?

[jennifer-shehane]

This function is expecting a string, but it's being passed an object so this won't ever compare correctly.

[cacieprins]

I'd waffled too many times between an obj and a string parameter - adding type declaration to parameter will help catch this in the future. addressed in 4af0b99

[cypress]

cypress    Run #56767

Run Properties:   Failed #56767  •  1a4d833797: Merge branch 'develop' into cacie/29880/unload-in-chromium

Project	cypress
Branch Review	cacie/29880/unload-in-chromium
Run status	Failed #56767
Run duration	36m 13s
Commit	1a4d833797: Merge branch 'develop' into cacie/29880/unload-in-chromium
Committer	Jennifer Shehane
View all properties for this run ↗︎

---

Test results
Failures	18
Flaky	2
Pending	10
Skipped	0
Passing	434
View all changes introduced in this branch ↗︎

---

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  67.9%
Untested elements	24
Tested elements	55

Accessibility  96.5%
Failed rules	0 critical   8 serious   3 moderate   0 minor
Failed elements	219

---

Tests for review

  cypress\e2e\runner\reporter-ct-webpack.errors.cy.ts • 18 failed tests • app-e2e

View Output

Test		Artifacts
Webpack - errors ui > assertion failures		Test Replay Screenshots
Webpack - errors ui > assertion failures - no preferred IDE		Test Replay Screenshots
Webpack - errors ui > exception failures		Test Replay Screenshots
Webpack - errors ui > hooks		Test Replay Screenshots
Webpack - errors ui > commands		Test Replay Screenshots
Webpack - errors ui > cy.then		Test Replay Screenshots
Webpack - errors ui > cy.should		Test Replay Screenshots
Webpack - errors ui > cy.each		Test Replay Screenshots
Webpack - errors ui > cy.spread		Test Replay Screenshots
Webpack - errors ui > cy.within		Test Replay Screenshots
The first 10 failed tests are shown, see all 18 tests in Cypress Cloud.

  cypress\e2e\runner\runner.ui.cy.ts • 0 failed tests • app-e2e

View Output

Test		Artifacts

  cypress\e2e\sidebar_navigation.cy.ts • 0 failed tests • app-e2e

View Output

Test		Artifacts

  cypress\e2e\runner\reporter-ct-vite.errors.cy.ts • 0 failed tests • app-e2e

View Output

Test		Artifacts

  cypress\e2e\settings.cy.ts • 0 failed tests • app-e2e

View Output

Test		Artifacts

The first 5 failed specs are shown, see all 49 specs in Cypress Cloud.

  cypress\e2e\runs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
... > displays a list of recorded runs if a run has been recorded		Test Replay Screenshots

  cypress\e2e\scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test		Artifacts
scaffolding component testing > react-vite-ts-unconfigured > detects react dependency even if `package.json` is not declared in `exports`		Test Replay Screenshots

[AtofStryker]

is this still relevant? Mostly curious how you tested this.

[cacieprins]

This is basically a cherry-picked patch from jQuery 3.7.1. when manually testing this in chrome, I was still receiving unload errors coming from jquery without this change

[jennifer-shehane]

I'm not seeing the unload warning displaying from our own code anymore. I still see one coming from jQuery but will have to test with the built binary I guess since that's patched.

[cypress-bot]

Released in 13.14.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.14.0, please open a new issue.