misc: replace marionette-client with geckodriver as b2g marionette client is no longer supported #30250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
misc/remove_marionette_for_geckodriver
branch
2 times, most recently
from
161ebbf
to
7a1dc85
Compare
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
misc/remove_marionette_for_geckodriver
|
| Run status |
|
| Run duration | 17m 26s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
1159
|
Skipped
|
0
|
Passing
|
15787
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
AtofStryker
force-pushed
the
misc/remove_marionette_for_geckodriver
branch
2 times, most recently
from
0a378dd
to
30b20e3
Compare
…ient is no longer supported [run ci]
AtofStryker
force-pushed
the
misc/remove_marionette_for_geckodriver
branch
7 times, most recently
from
516e9da
to
32b19a0
Compare
…er to own class [run ci]
AtofStryker
force-pushed
the
misc/remove_marionette_for_geckodriver
branch
from
32b19a0
to
21b06a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
As a precursor to supporting WebDriver BiDi, Cypress needs to replace the older marionette-client with geckodriver. This is the current recommendation from the Mozilla team as
marionette-clientis no longer supported (see Cypress migration bugzilla ticket).Currently, the responsibilities of the current
geckodriverimplementation and the oldermarionette-client:WebDriver Classicsession.WebDriver Classicto navigate the browser. This will be replaced by BiDi in the future.Marionetteto install the Cypress Web Extension.This is outlined in the added
READMEin this PR as well as some other useful information. This information will be updated as we implementBiDi.It is worth noting that we patch the
geckodriverpackage to coincide with our debug logs in order to not print extraneous messages to the console that could disrupt end user experience as well as impact our system tests. We also need to patch top-level awaits to correctly build the app.To consume
GeckoDriver, this code installs thegeckodriverpackage, a lightweight wrapper around the geckodriver binary, to connect to the Firefox browser.geckodriverwill be downloaded automatically to the user'stmpdirectory if not already downloaded, and will be started and managed by the Cypress server.Steps to test
Unit tests have been updated to reflect the replaced client, as well as tests added for our
geckodriverwrapper.The
system-testsandintegrationtests serve as a regression suite to help guarantee this change works.Manual testing should also be completed on
linux,mac, andwindowsin open/run mode permutations to verify the code and client changes work universally. The app team will be participating in a small bughunt to identify issues we may have not already found.How has the user experience changed?
Ideally, this change should NOT impact the end user. This is an internal swap of a client used to automate the browser and should not affect the end user in any way.
PR Tasks
cypress-documentation?type definitions?