Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @da2ce7, this is my feedback for this.
It's not finished yet.
Why did I rename the
Clock
?The
Clock
return an instance of itself, and it's the time. I see theClock
as the service and theTime
as the value object. In this implementation, you do not use the service, only a value object that instantiates by itself.With the new name, you see:
With the previous name, you read:
It's a little weird that the variable
current_time
is aUnixClock
.