Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding some basic styles for DL lists #286

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adding some basic styles for DL lists #286

wants to merge 2 commits into from

Conversation

alpower
Copy link
Contributor

@alpower alpower commented Oct 2, 2018 •
edited
Loading

Adding some basic classed styles for DL lists - list, stacked, inline for #215

  • added to budo example
  • added less variables
  • add styleguidist app examples
  • add styleguidist less variable examples
@dl-label-width: @label-width;
@dl-label-color: @grey-medium;

image

JakeSidSmith
JakeSidSmith reviewed Oct 15, 2018
View reviewed changes
src/less/text.less Outdated
content: ', ';
}

dd.last:after {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this is necessary?

Copy link
Contributor Author

@alpower alpower Oct 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was def there for a reason that I can't remember now. Will spin it up and check and respond :) there might be a better solution.

definition list improvements
c171ab4 
Removed last class and switched to separate lists for the inline style.
Added example for Styleguidist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeSidSmith JakeSidSmith JakeSidSmith left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpower @JakeSidSmith