fixup: use isDetachedBuffer only

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
daeyeon · Aug 4, 2022 · 6f6ba3e · 6f6ba3e
1 parent 50c7728
commit 6f6ba3e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
@@ -102,7 +102,6 @@ const {
   extractSizeAlgorithm,
   lazyTransfer,
   isDetachedBuffer,
-  isViewedArrayBufferDetached,
   isBrandCheck,
   resetQueue,
   setPromiseHandled,
@@ -684,7 +683,7 @@ class ReadableStreamBYOBRequest {
         'This BYOB request has been invalidated');
     }
 
-    if (isViewedArrayBufferDetached(view)) {
+    if (isDetachedBuffer(ArrayBufferViewGetBuffer(view))) {
       throw new ERR_INVALID_STATE.TypeError('Viewed ArrayBuffer is detached');
     }
 

diff --git a/lib/internal/webstreams/util.js b/lib/internal/webstreams/util.js
@@ -130,23 +130,14 @@ function transferArrayBuffer(buffer) {
 }
 
 function isDetachedBuffer(buffer) {
-  if (ArrayBufferGetByteLength(buffer) === 0) {
-    try {
-      new Uint8Array(buffer);
-    } catch {
-      return true;
-    }
+  try {
+    new Uint8Array(buffer);
+  } catch {
+    return true;
   }
   return false;
 }
 
-function isViewedArrayBufferDetached(view) {
-  return (
-    ArrayBufferViewGetByteLength(view) === 0 &&
-    isDetachedBuffer(ArrayBufferViewGetBuffer(view))
-  );
-}
-
 function dequeueValue(controller) {
   assert(controller[kState].queue !== undefined);
   assert(controller[kState].queueTotalSize !== undefined);
@@ -245,7 +236,6 @@ module.exports = {
   isBrandCheck,
   isDetachedBuffer,
   isPromisePending,
-  isViewedArrayBufferDetached,
   peekQueueValue,
   resetQueue,
   setPromiseHandled,