Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for nightmode switch #83

Merged
merged 5 commits into from
Mar 18, 2024
Merged

feat: Add support for nightmode switch #83

merged 5 commits into from
Mar 18, 2024

Conversation

jonathanrobichaud4
Copy link
Contributor

No description provided.

@jonathanrobichaud4
Add support for nightmode. Not sure if I had to modify both of the da…
019a15c 
…ta_update_coordinator files but did just in case
dahlb
dahlb reviewed Mar 17, 2024
View reviewed changes
custom_components/ha_blueair/switch.py Outdated
super().__init__("Night Mode", device)

@property
def is_on(self) -> int | None:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this should be -> bool | None from ToggleEntity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good I just used the same code for the child lock switch which is an int but that makes more sense.

@dahlb
Copy link
Owner

dahlb commented Mar 17, 2024

three lint errors
custom_components/ha_blueair/blueair_aws_data_update_coordinator.py:149:1: W293 [] Blank line contains whitespace
custom_components/ha_blueair/blueair_data_update_coordinator.py:90:1: W293 [] Blank line contains whitespace
custom_components/ha_blueair/switch.py:66:1: W293 [*] Blank line contains whitespace

@dahlb dahlb changed the title Add support for nightmode feat: Add support for nightmode switch Mar 17, 2024
@dahlb
Copy link
Owner

dahlb commented Mar 17, 2024

once the api pr is merged please update
requirements.txt and manifest.json with newly released version for blueair-api

@jonathanrobichaud4
Copy link
Contributor Author

once the api pr is merged please update requirements.txt and manifest.json with newly released version for blueair-api

Will do a separate commit for that, I'm just submitting what I have now for your review!

@jonathanrobichaud4
Copy link
Contributor Author

Ok I have updated the blueair-api strings in the files. I haven't changed the integration version in manifest.json though

@dahlb
Copy link
Owner

dahlb commented Mar 18, 2024

Needs an upstream merge to resolve a conflict in requirements from ruff being updated by dependabot

@jonathanrobichaud4
Copy link
Contributor Author

Ok fixed!

@dahlb dahlb merged commit 5df17f9 into dahlb:main Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlb dahlb dahlb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanrobichaud4 @dahlb