Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: multiple elements in a single response #124

Merged
merged 38 commits into from
Sep 11, 2023
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Sep 1, 2023

There are many changes, but what's important is

  • Supports multiple elements in one RSC payload
    • One single input string
  • entries.tsx is changed
    • renderEntries instead of getEntry
  • Explicit refetch on client
  • Refactor waku/router
    • Do not cache on client
    • Pass path as a prop

Close #119
Close #84
Close #104
Close #85

Check list:

  • examples/01
  • examples/02
  • examples/03
  • examples/04
  • examples/05
  • examples/06
  • examples/07
  • examples/08
  • examples/09

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 7:41am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bec7d16:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration

@dai-shi dai-shi marked this pull request as ready for review September 10, 2023 06:53
@dai-shi dai-shi mentioned this pull request Sep 10, 2023
@dai-shi dai-shi changed the title feat: multiple elements in a single response breaking: multiple elements in a single response Sep 10, 2023
@dai-shi dai-shi mentioned this pull request Sep 10, 2023
76 tasks
@dai-shi
Copy link
Owner Author

dai-shi commented Sep 10, 2023

Hmm, I wonder if we should have client based caching option...

Copy link
Owner Author

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still room for improvement, but I think I need some feedback. Let's merge it and ship it.

@dai-shi dai-shi merged commit bf9a0fb into main Sep 11, 2023
7 checks passed
@dai-shi dai-shi deleted the feat/rscs-in-a-response branch September 11, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant