breaking: no index html

CHANGELOG.md

@@ -1,6 +1,8 @@
 # Change Log
 
 ## [Unreleased]
+### Added
+- breaking: no index html #289
 
 ## [0.18.1] - 2023-12-15
 ### Changed

e2e/examples-smoke.spec.ts

@@ -116,8 +116,9 @@ for (const cwd of examples) {
 
         test('check title', async ({ page }) => {
           await page.goto(`http://localhost:${port}/`);
-          const title = await page.title();
-          expect(title).toBe('Waku example');
+          // title maybe doesn't ready yet
+          await page.waitForLoadState('load');
+          await expect.poll(() => page.title()).toBe('Waku example');
         });
       });
     }
@@ -173,8 +174,7 @@ for (const cwd of examples) {
           await page.goto(`http://localhost:${port}/`);
           // title maybe doesn't ready yet
           await page.waitForLoadState('load');
-          const title = await page.title();
-          expect(title).toBe('Waku example');
+          await expect.poll(() => page.title()).toBe('Waku example');
         });
       });
     }

e2e/fixtures/rsc-basic/src/components/App.tsx

@@ -8,6 +8,7 @@ import { ServerBox } from './Box.js';
 const App = ({ name }: { name: string }) => {
   return (
     <ServerBox>
+      <title>Waku example</title>
       <p data-testid="app-name">{name}</p>
       <ClientCounter />
       <ServerPing />

e2e/fixtures/rsc-basic/src/main.tsx

@@ -10,4 +10,4 @@ const rootElement = (
   </StrictMode>
 );
 
-createRoot(document.getElementById('root')!).render(rootElement);
+createRoot(document.body).render(rootElement);

e2e/fixtures/rsc-router/src/main.tsx

@@ -8,4 +8,4 @@ const rootElement = (
   </StrictMode>
 );
 
-createRoot(document.getElementById('root')!).render(rootElement);
+createRoot(document.body).render(rootElement);

e2e/fixtures/rsc-router/src/routes/layout.tsx

@@ -16,6 +16,7 @@ const Pending = ({ isPending }: { isPending: boolean }) => (
 
 const HomeLayout = ({ children }: { children: ReactNode }) => (
   <div>
+    <title>Waku example</title>
     <ul>
       <li>
         <Link

e2e/fixtures/ssr-basic/src/components/App.tsx

@@ -3,6 +3,7 @@ import { Counter } from './Counter.js';
 const App = ({ name }: { name: string }) => {
   return (
     <div style={{ border: '3px red dashed', margin: '1em', padding: '1em' }}>
+      <title>Waku example</title>
       <h1 data-testid="app-name">{name}</h1>
       <Counter />
     </div>

e2e/fixtures/ssr-basic/src/main.tsx

@@ -11,7 +11,7 @@ const rootElement = (
 );
 
 if ((globalThis as any).__WAKU_SSR_ENABLED__) {
-  hydrateRoot(document.getElementById('root')!, rootElement);
+  hydrateRoot(document.body, rootElement);
 } else {
-  createRoot(document.getElementById('root')!).render(rootElement);
+  createRoot(document.body).render(rootElement);
 }

examples/01_counter/src/components/App.tsx

@@ -3,6 +3,7 @@ import { Counter } from './Counter.js';
 const App = ({ name }: { name: string }) => {
   return (
     <div style={{ border: '3px red dashed', margin: '1em', padding: '1em' }}>
+      <title>Waku example</title>
       <h1>Hello {name}!!</h1>
       <h3>This is a server component.</h3>
       <Counter />

examples/01_counter/src/main.tsx

@@ -11,7 +11,7 @@ const rootElement = (
 );
 
 if ((globalThis as any).__WAKU_SSR_ENABLED__) {
-  hydrateRoot(document.getElementById('root')!, rootElement);
+  hydrateRoot(document.body, rootElement);
 } else {
-  createRoot(document.getElementById('root')!).render(rootElement);
+  createRoot(document.body).render(rootElement);
 }

examples/02_async/src/components/App.tsx

@@ -7,6 +7,7 @@ import { Counter } from './Counter.js';
 const App = ({ name }: { name: string }) => {
   return (
     <div style={{ border: '3px red dashed', margin: '1em', padding: '1em' }}>
+      <title>Waku example</title>
       <h1>Hello {name}!!</h1>
       <h3>This is a server component.</h3>
       <Suspense fallback="Pending...">

examples/02_async/src/main.tsx

@@ -11,7 +11,7 @@ const rootElement = (
 );
 
 if ((globalThis as any).__WAKU_SSR_ENABLED__) {
-  hydrateRoot(document.getElementById('root')!, rootElement);
+  hydrateRoot(document.body, rootElement);
 } else {
-  createRoot(document.getElementById('root')!).render(rootElement);
+  createRoot(document.body).render(rootElement);
 }

examples/03_promise/src/components/App.tsx

@@ -8,6 +8,7 @@ const App = ({ name, children }: { name: string; children: ReactNode }) => {
   });
   return (
     <div style={{ border: '3px red dashed', margin: '1em', padding: '1em' }}>
+      <title>Waku example</title>
       <h1>Hello {name}!!</h1>
       <h3>This is a server component.</h3>
       <Counter delayedMessage={delayedMessage} />

examples/03_promise/src/main.tsx

@@ -13,7 +13,7 @@ const rootElement = (
 );
 
 if ((globalThis as any).__WAKU_SSR_ENABLED__) {
-  hydrateRoot(document.getElementById('root')!, rootElement);
+  hydrateRoot(document.body, rootElement);
 } else {
-  createRoot(document.getElementById('root')!).render(rootElement);
+  createRoot(document.body).render(rootElement);
 }