breaking: server to allow fallback to static #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 94a0e70:
|
dai-shi
commented
Dec 23, 2023
| @@ -4,6 +4,11 @@ export default defineConfig(({ mode }) => { | |||
| process.env = { ...process.env, ...loadEnv(mode, process.cwd()) }; | |||
| if (mode === 'development') { | |||
| return { | |||
| optimizeDeps: { | |||
| include: [ | |||
| // '@uidotdev/usehooks', | |||
There was a problem hiding this comment.
I expected this would improve npm run website:dev, but it makes it worse (errors) if we remove --with-ssr.
|
It was the issue of #289. We should solve it, but let's move on this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I wanted for some time.
Now, we can skip rendering RSC and/or HTML on the server.
In addition to it, with router, we can let the client to skip requesting for some/all route components.
It's working as expected, but now I fee the API and the core implementation is full of hacks. It's not easy to understand and thus not very maintainable for the future.
We should revisit it after getting some feedbacks.