Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid website issues #345

Merged
merged 1 commit into from
Jan 3, 2024
Merged

chore: avoid website issues #345

merged 1 commit into from
Jan 3, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Jan 3, 2024

and minor fixes.

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jan 3, 2024 1:59pm

Copy link

codesandbox-ci bot commented Jan 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f5efadc:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

Comment on lines +7 to +8
// FIXME this causes an error with `--with-ssr`
// include: ['@uidotdev/usehooks'],
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to make website work in development in both with and without --with-ssr.

@dai-shi
Copy link
Owner Author

dai-shi commented Jan 3, 2024

This PR doesn't fix anything. Follow-up in #344.

@dai-shi dai-shi merged commit 5bdadbe into main Jan 3, 2024
28 checks passed
@dai-shi dai-shi deleted the fix/website branch January 3, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant