Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: loading indicator to mitigate FOUC #414

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Jan 22, 2024

part of #344

image

Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jan 22, 2024 2:34pm

Copy link

codesandbox-ci bot commented Jan 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e651e47:

Sandbox Source
Vanilla Typescript Configuration
React Configuration
React TypeScript Configuration

Comment on lines +57 to +60
style:
'position: fixed; top: 0; left: 0; right: 0; bottom: 0; background: rgba(0, 0, 0, 0.8); display: flex; align-items: center; justify-content: center; font-family: sans-serif; font-size: 2rem; color: white; cursor: wait;',
},
children: 'Loading...',
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandren Feel free to improve this.

@dai-shi dai-shi merged commit 0be5fb4 into main Jan 22, 2024
28 checks passed
@dai-shi dai-shi deleted the dev-loading-indicator branch January 22, 2024 14:50
@dai-shi dai-shi mentioned this pull request Jan 23, 2024
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant