Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(waku/router): prefetch on view (<Link />) #672

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

bysxx
Copy link
Contributor

@bysxx bysxx commented Apr 26, 2024

This is the props I needed. If this component is exposed to the screen, prefetch target route

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Apr 26, 2024 9:27am

@bysxx bysxx changed the title prefetch on view (<Link /> prefetch on view (<Link />) Apr 26, 2024
Copy link

codesandbox-ci bot commented Apr 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

feat: update prefetch on view
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Added some comments.

packages/waku/src/router/client.ts Show resolved Hide resolved
packages/waku/src/router/client.ts Outdated Show resolved Hide resolved
packages/waku/src/router/client.ts Outdated Show resolved Hide resolved
@bysxx
Copy link
Contributor Author

bysxx commented Apr 26, 2024

@dai-shi I don't know if I fully understand what you said, but I applied it first! Please feedback!

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
You got it correctly.

@dai-shi dai-shi changed the title prefetch on view (<Link />) feat(waku/router): prefetch on view (<Link />) Apr 26, 2024
@dai-shi dai-shi merged commit 1b3a48d into dai-shi:main Apr 26, 2024
28 checks passed
@dai-shi dai-shi mentioned this pull request Apr 26, 2024
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants