error in error handling #896
Merged
+222
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Otherwise the error boundary itself will throw "In HTML, <h1> cannot be a child of <#document>. This will cause a hydration error." which will result in an infinite re-rendering loop.
pmelab
force-pushed
the
error-in-error-handling
branch
from
2b8eae0
to
e6e3f6e
Compare
dai-shi
approved these changes
Sep 24, 2024
Comment on lines
+554
to
+560
| function renderError(message: string) { | ||
| return createElement( | ||
| 'html', | ||
| null, | ||
| createElement('body', null, createElement('h1', null, message)), | ||
| ); | ||
| } |
There was a problem hiding this comment.
This doesn't feel like a final solution, but it looks good to me for now at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error boundary does not render
htmlorbodytags and therefore causes and error itself.