Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: partially for css modules #98

Merged
merged 5 commits into from
Jul 10, 2023
Merged

fix: partially for css modules #98

merged 5 commits into from
Jul 10, 2023

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Jul 3, 2023

related #90

  • fix ssr server error
  • bundle css modules in dev
  • bundle css modules in build

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2023 7:17am

@dai-shi dai-shi marked this pull request as draft July 3, 2023 04:54
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 3, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6e5cf9b:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
React Configuration
React Typescript Configuration

@dai-shi dai-shi mentioned this pull request Jul 3, 2023
@dai-shi dai-shi changed the title wip: fix ssr server feat: css modules Jul 3, 2023
@dai-shi dai-shi mentioned this pull request Jul 8, 2023
76 tasks
margin-top: calc(50% - 18px);
}
</style>
<link rel="stylesheet" href="/components/App.module.css" />
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hack. We shouldn't need it. Let's live with it in the mean time and look for proper fix later. We need someone to help on it.

@dai-shi dai-shi marked this pull request as ready for review July 8, 2023 07:19
@dai-shi
Copy link
Owner Author

dai-shi commented Jul 10, 2023

Unfortunately, this alone doesn't solve the #90 issue. However, the change itself is valid and partially solves the issue.

@dai-shi dai-shi changed the title feat: css modules fix: partially for css modules Jul 10, 2023
@dai-shi dai-shi merged commit 5af1c34 into main Jul 10, 2023
5 checks passed
@dai-shi dai-shi deleted the fix/css-modules branch July 10, 2023 05:41
@dai-shi dai-shi mentioned this pull request Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant