Fix unnecessary auto-Raise() of toplevel window whenever it gets acti… #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vated. This is unnecessary (this is task of the window manager), and actively annoying on focus-follows-mouse systems as the window pops to the front on slight mouse over. This is only needed to work around buggy behavior of the window manager in OSX, so only activate it in that case.
|
This is the improved pull request based on the discussion in pull request #1357 . |
|
Any chance to get this in ? I always stumble upon the problem solved here whenever I install it on a new machine with focus-follows-mouse. |
|
@daid is on a holiday now. I don't know enough about the old Cura base to confidently merge this. |
|
Does the change look good enough to merge ? |
|
As far as I'm concerned it does, but the old Cura is hacked together like there is no tomorrow. Any changes that are made will probalby have impact on other bits. Daid is the only one who knows where all the issues are, so he's the guy to merge it. |
|
@daid can this be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vated.
This is unnecessary (this is task of the window manager),
and actively annoying on focus-follows-mouse systems as the window
pops to the front on slight mouse over.
This is only needed to work around buggy behavior of the window
manager in OSX, so only activate it in that case.