Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements DynSignatureAlgorithmIdentifier trait for ed25519 #712

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Implements DynSignatureAlgorithmIdentifier trait for ed25519 #712

merged 4 commits into from
Oct 8, 2024

Conversation

juliusl
Copy link
Contributor

@juliusl juliusl commented Oct 3, 2024 •
edited
Loading

  • Implements DynSignatureAlgorithmIdentifier trait for SigningKey/VerifyingKey from ed25519-dalek

Addresses #707

@juliusl juliusl changed the title Adds x509-cert support for ed25519 Implements DynSignatureAlgorithmIdentifier trait for ed25519 Oct 3, 2024
@juliusl juliusl force-pushed the pr/impl-spki-algo-identifier-trait branch from e0fc46c to a1155b6 Compare October 3, 2024 20:00
@rozbb
Copy link
Contributor

rozbb commented Oct 5, 2024

Thank you! It looks like CI fails because you use som alloc features. Feel free to copy the gate used elsewhere in signing.rs:

#[cfg(all(feature = "alloc", feature = "pkcs8"))]

@tarcieri tarcieri merged commit 43a16f0 into dalek-cryptography:main Oct 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusl @rozbb @tarcieri