Skip to content

Commit

Permalink
Update linting command and fix method signatures
Browse files Browse the repository at this point in the history
  • Loading branch information
FabianGosebrink committed Mar 18, 2024
1 parent b02b893 commit 8b45cf2
Show file tree
Hide file tree
Showing 10 changed files with 22 additions and 25 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
run: npm ci

- name: Linting Frontend
run: npm run lint-lib
run: npm run lint

- name: Testing Frontend
run: npm run test-lib-ci
Expand Down
2 changes: 1 addition & 1 deletion lefthook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pre-commit:
run: npm run check-blockwords

lint:
run: npm run lint-lib
run: npm run lint
#
# pre-commit:
# parallel: true
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"build-lib-prod": "ng build angular-auth-oidc-client --configuration production && npm run schematics-build && npm run copy-files",
"test-lib": "ng test angular-auth-oidc-client --code-coverage",
"test-lib-ci": "ng test angular-auth-oidc-client --watch=false --browsers=ChromeHeadlessNoSandbox --code-coverage",
"lint-lib": "ng lint angular-auth-oidc-client",
"pack-lib": "npm run build-lib-prod && npm pack ./dist/angular-auth-oidc-client",
"publish-lib": "npm run build-lib-prod && npm publish ./dist/angular-auth-oidc-client",
"publish-lib-next": "npm run build-lib && npm publish --tag next ./dist/angular-auth-oidc-client",
Expand Down
10 changes: 5 additions & 5 deletions projects/sample-code-flow-auto-login/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,26 +9,26 @@ import { OidcSecurityService } from 'angular-auth-oidc-client';
export class AppComponent implements OnInit {
constructor(private readonly oidcSecurityService: OidcSecurityService) {}

ngOnInit() {
ngOnInit(): void {
this.oidcSecurityService
.checkAuth()
.subscribe(({ isAuthenticated, userData, accessToken }) => {
.subscribe(({ isAuthenticated, accessToken }) => {
console.log('app authenticated', isAuthenticated);
console.log(`Current access token is '${accessToken}'`);
});
}

login() {
login(): void {
console.log('start login');
this.oidcSecurityService.authorize();
}

refreshSession() {
refreshSession(): void {
console.log('start refreshSession');
this.oidcSecurityService.authorize();
}

logout() {
logout(): void {
console.log('start logoff');
this.oidcSecurityService
.logoff()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export class ForbiddenComponent implements OnInit {

constructor(private readonly oidcSecurityService: OidcSecurityService) {}

ngOnInit() {
ngOnInit(): void {
this.oidcSecurityService.isAuthenticated$.subscribe(
({ isAuthenticated }) => {
this.isAuthenticated = isAuthenticated;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export class HomeComponent implements OnInit {

constructor(public oidcSecurityService: OidcSecurityService) {}

ngOnInit() {
ngOnInit(): void {
this.oidcSecurityService.isAuthenticated$.subscribe(
({ isAuthenticated }) => {
this.isAuthenticated = isAuthenticated;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export class NavigationComponent implements OnInit {

constructor(public oidcSecurityService: OidcSecurityService) {}

ngOnInit() {
ngOnInit(): void {
this.oidcSecurityService.isAuthenticated$.subscribe(
({ isAuthenticated }) => {
this.isAuthenticated = isAuthenticated;
Expand All @@ -21,15 +21,15 @@ export class NavigationComponent implements OnInit {
);
}

login() {
login(): void {
this.oidcSecurityService.authorize();
}

refreshSession() {
refreshSession(): void {
this.oidcSecurityService.authorize();
}

logout() {
logout(): void {
this.oidcSecurityService
.logoff()
.subscribe((result) => console.log(result));
Expand Down
12 changes: 5 additions & 7 deletions projects/sample-code-flow-http-config/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,13 @@ export class AppComponent implements OnInit {
private readonly eventService: PublicEventsService
) {}

ngOnInit() {
ngOnInit(): void {
this.oidcSecurityService
.checkAuth()
.subscribe(
({ isAuthenticated, userData, accessToken, idToken, configId }) => {
console.log('app authenticated', isAuthenticated);
console.log(`Current access token is '${accessToken}'`);
}
);
.subscribe(({ isAuthenticated, accessToken }) => {
console.log('app authenticated', isAuthenticated);
console.log(`Current access token is '${accessToken}'`);
});

this.eventService
.registerForEvents()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { OidcSecurityService } from 'angular-auth-oidc-client';
export class AppComponent implements OnInit {
constructor(public oidcSecurityService: OidcSecurityService) {}

ngOnInit() {
ngOnInit(): void {
this.oidcSecurityService
.checkAuthMultiple()
.subscribe(([{ isAuthenticated, userData, accessToken }]) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ export class HomeComponent {

constructor(public oidcSecurityService: OidcSecurityService) {}

login(configId: string | undefined) {
login(configId: string | undefined): void {
this.oidcSecurityService.authorize(configId);
}

forceRefreshSession() {
forceRefreshSession(): void {
this.oidcSecurityService
.forceRefreshSession()
.subscribe((result) => console.warn(result));
}

logout(configId: string | undefined) {
logout(configId: string | undefined): void {
this.oidcSecurityService.logoff(configId);
}
}

0 comments on commit 8b45cf2

Please sign in to comment.