Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for detection and addition of ome/ngff "standard" into assets summary #252

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

TODOs

  • test?
  • different level of version jump?

we will need to release so that dandi-archive could take advantage of it

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.69%. Comparing base (6fc16b8) to head (551faf7).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
dandischema/metadata.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
- Coverage   97.75%   97.69%   -0.07%     
==========================================
  Files          16       16              
  Lines        1739     1780      +41     
==========================================
+ Hits         1700     1739      +39     
- Misses         39       41       +2     
Flag Coverage Δ
unittests 97.69% <77.77%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dandischema/models.py Outdated Show resolved Hide resolved
We already use DOI: prefix in few places seems, to chose it over direct
URL.
dandischema/models.py Outdated Show resolved Hide resolved
Not sure why originally I used OME/NGFF -- everywhere it is OME-NGFF and also other flavors like OME-TIFF etc

Co-authored-by: Satrajit Ghosh <satra@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants