Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image with CSS max-width and max-height incorrectly scaled up #242

Closed
koan00 opened this issue Jul 6, 2018 · 0 comments
Closed

Image with CSS max-width and max-height incorrectly scaled up #242

koan00 opened this issue Jul 6, 2018 · 0 comments

Comments

@koan00
Copy link

koan00 commented Jul 6, 2018 •
edited
Loading

When the image supplied is smaller than both the max-width and max-height, the image is scaled up. Css max attributes should only result in down scale. When only one of the two max attributes is supplied, the up-scaling does not occur.

<html><head></head><body>
<img style="max-height: 950px; max-width: 710px" src="https://pbs.twimg.com/profile_images/638747380494503936/C89d1hl3_400x400.jpg" />
</body></html>
koan00 pushed a commit to koan00/openhtmltopdf that referenced this issue Jul 6, 2018
Fix danfickle#242 - Image with CSS max-width and max-height incorrect…
34f7425 
…ly scaled up.
@koan00 koan00 mentioned this issue Jul 6, 2018
Merged
danfickle added a commit that referenced this issue Jul 7, 2018
@danfickle
Merge pull request #243 from koan00/open-dev-v1
b8a6ab0 
Fix #242 - Image with CSS max-width and max-height incorrectly scaled up
@danfickle danfickle mentioned this issue Jul 7, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@koan00