Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework URI resolver so it can be used with any base uri. #27

Closed
danfickle opened this issue Jun 25, 2016 · 2 comments
Closed

Rework URI resolver so it can be used with any base uri. #27

danfickle opened this issue Jun 25, 2016 · 2 comments

Comments

@danfickle
Copy link
Owner

Currently it only works with the document base uri. This means it can not be used for import statements in CSS which should be relative to the CSS document. It is also a mess of code.

Once it is fixed, make sure the CSS parser uses it for import statements instead of bypassing the user agent resolver altogether.

Probably a breaking change.
danfickle added a commit that referenced this issue Jun 26, 2016
@danfickle
For #27 - Make URI resolver stateless so it can resolve URIs with var…
c6602ef 
…ious base URIs.

Also:
- Make sure everything goes through the URI resolver.
- Log where the URI resolver rejects (or cannot resolve) a resource.
- New example in integration guide.
danfickle added a commit that referenced this issue Jun 26, 2016
@danfickle
For #27 - Make tests run again.
1714d82 
We no longer have defined behavior when resolving a relative URI
without a base URI. This is marked as a breaking change in the change
log.
@danfickle
Copy link
Owner Author

BREAKING CHANGE: We no longer have defined behavior for when a relative URI is used with no base URI. It would previously use the current working directory.

BREAKING CHANGE: The FSUriResolver interface has changed to be stateless to allow different base URIs to be used depending whether we are importing from the xhtml document or CSS stylesheet. It is now able to be used as a functional interface too.

@danfickle
Copy link
Owner Author

It is now not resolving URIs inside inline style declarations:

<div style="background-image: url(../images/go-home.png);"></div>

@danfickle danfickle reopened this Aug 3, 2016
@danfickle danfickle mentioned this issue Aug 28, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danfickle