Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it possible to set a producer #158

Merged
merged 1 commit into from
Dec 16, 2017
Merged

make it possible to set a producer #158

merged 1 commit into from
Dec 16, 2017

Conversation

schmitch
Copy link
Contributor

currently the producer defaults to openhtmltopdf.com while I think that is sane in the most cases. it's sometimes not wished to actually "show" which library was used to produce pdfs.

rototor
rototor approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@rototor rototor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that the constructor arguments are going to explode as their are more and more arguments.

But other than that, this looks fine to me.

@danfickle
Copy link
Owner

Thanks again @schmitch
Thanks for taking a look @rototor

Merging now.

@danfickle danfickle merged commit 688b846 into danfickle:open-dev-v1 Dec 16, 2017
@danfickle danfickle mentioned this pull request Apr 5, 2018
Open
@andy-clapson andy-clapson mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rototor rototor rototor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmitch @danfickle @rototor