Testcase big document #180 #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis instances...
but we dont really need to synchronized on a the XRLog class, as this only slows everything down (especially when we are multithreaded, as isLoggingEnabled() is called *often* in the code).
HotSpot *should* remove that anyway, but better not rely on it.
also don't need a copy of a readonly list, if we only consume it without it. In the "Bucket" sort we can lazy create the ArrayList. And of course: Always use a ArrayList, because its in 99% always faster then a LinkedList (as LinkedList don't play that well with the CPU cache...)
the locking performed on it. The time FS was started there simply was no StringBuilder so of course StringBuffer got used... The HotSpot *should* always be able to remove the unneeded synchronized on the StringBuffer, but there is no guarantee. If there is no synchronized because of the StringBuilder it doesn't need to do anything.
providing interactive swing controls.
multithreading here any more. This just makes everything slower.
rototor
commented
Apr 6, 2018
| } | ||
| } | ||
| infos.addAll(Arrays.asList(refs)); |
There was a problem hiding this comment.
This is something IDEA cached ... if refs == null, the addAll would throw an NPE...
rototor
commented
Apr 6, 2018
| } | ||
| return list.iterator(); | ||
| public java.util.Collection<PropertyDeclaration> getCascadedPropertyDeclarations() { | ||
| return cascadedProperties.values(); |
There was a problem hiding this comment.
This collection here is always directly consumed and iterated over. There was no sense in copying this...
rototor
commented
Apr 6, 2018
| [#macro h4][@hn 4][#nested][/@hn][/#macro] | ||
|
|
||
|
|
||
| [#list 1..100 as page] |
There was a problem hiding this comment.
increase this count here for way more pages
rototor
commented
Apr 6, 2018
| </thead> | ||
|
|
||
| <tbody> | ||
| [#list 1..1000 as subRow] |
There was a problem hiding this comment.
This count is high at the moment, before merging this branch it should be decreased to a sensible value, as travis won't finish with such many rows...
|
I’m going to work on style caching now. Provided there are no sibling selectors or custom nth-child I think we can do a much better job at avoiding running the cascade for every element. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #180
This takes 5m 49s on my MacBook Pro 2014 to create a HTML file with 18.5 MB and a result PDF with 232 MB and 12694 pages using JDK 1.7.0_52.
Feel free to change the list directive
from 5000 to something smaller.