New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make loading resources from classpath work when openhtmltopdf is a named module #301

Merged

danfickle merged 1 commit into danfickle:open-dev-v1 from zimmi:module-resource-loading

Dec 5, 2018

Contributor

zimmi commented Dec 4, 2018

Using Class::getResource* works on both module- and classpath (see here), the code was using ClassLoader::getResource* previously.

I added some tests to verify the classpath behavior still works. Still not sure how to test the module path behavior properly though.


          make classpath loading work as a named module

5b6eaef

Owner

danfickle commented Dec 5, 2018

Thanks @zimmi. Looks good.

danfickle merged commit 506f84d into danfickle:open-dev-v1

danfickle mentioned this pull request

Upload to maven central via bintray. #7

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet