Fix warnings for icon font without space inside PDF/A, add tests #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It failed because we always use the built in serif as a fallback if PDF/A conformance is not required. Your code looks fine so merging now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Googles MaterialIcons-Font does not contain a space character. When using PDF/A, the layout algorithm tries to eagerly find out the width of the space character. This does not happen when PDF/A is not used.
I changed the algorithm to only query for the width if there is actually a space inside the element.
Added tests to verify the fix (the PDF/A one failed previously).