Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control of PDPage creation via PDFCreationListener #334

Merged
merged 8 commits into from
Mar 13, 2019

Commits on Mar 8, 2019

  1. Merge pull request #1 from danfickle/open-dev-v1

    Update to Head
    DSW-PS authored Mar 8, 2019
    Configuration menu
    Copy the full SHA
    4df0b80 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Merge pull request #2 from danfickle/open-dev-v1

    Update to head
    DSW-PS authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    5ea56e8 View commit details
    Browse the repository at this point in the history
  2. onCreatePage for PDFCreationListener

    Added onCreatePage to PDFCreationListener.
    Added fireOnCreatePage to PdfBoxRenderer - by default this just creates
    a PDPage and adds it to the PDDocument (old behavior).
    
    This allows the user more control over the page that is created and also
    control when (or if) a page is to be added to the PDDocument.
    ps authored and ps committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    06b0c8d View commit details
    Browse the repository at this point in the history
  3. Renamed fireOnCreate to fireOnCreatePage

    ps authored and ps committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    834f1e8 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #3 from danfickle/open-dev-v1

    danfickle#8 Online sandbox now at RC18. [ci skip]
    DSW-PS authored Mar 11, 2019
    Configuration menu
    Copy the full SHA
    e6aa50e View commit details
    Browse the repository at this point in the history
  5. PageSupplier instead of PDFCreationListener.onCreatePage (PR#334)

    (See danfickle#334)
    
    Based on the suggested by @danfickle, reverted the changes to
    PDFCreationListener and PdfBoxRenderer, instead a PageSupplier can be
    set via the PdfRendererBuilder.
    
    The PageSupplier.requestPage allows the user to create a new page or
    supply an existing one where the Html will be printed.
    
    PdfRendererBuilder implements PageSupplier and simply creates a new page
    and adds it to the PDDocument.
    ps authored and ps committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    9ed5f86 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'open-dev-v1' of https://github.com/DSW-PS/openhtmltopdf

    …into open-dev-v1
    ps authored and ps committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    3808c67 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Fixed incorrect pageNumber arguments in shadow-page loop.

    Added a brief explanation what "shadow-pages" are to the PageSupplier.
    As @danfickle pointed out, the current-page index (i) should be used as
    pageNumber argument for PageSupplier in PdfBoxRenderer when building the
    shadow-pages and not the pdfPageIndex (which at this point has already
    been upped by one).
    Also first call to PageSupplier should (for the first page) should be
    with pageNumber 0, not 1.
    ps authored and ps committed Mar 13, 2019
    Configuration menu
    Copy the full SHA
    c16e049 View commit details
    Browse the repository at this point in the history