#482: Smoke Testcase for the endless loop because of white-space hand… #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a special case only for this single case: Line-Width is 0 and the line only contains of a soft-hypen. In this case we don't need to try to break on the character level, as this will not work, but will lead to a endless loop. So we pretend we already did try to break on the character level. This ends the loop for this line.
|
This is no longer a smoke test, but also provides a fix for this problem which seems to work and not break any other test. |
|
hi @rototor , I may be wrong, but I think it will still fail if the string is larger than 1 but contains only SOFT_HYPHEN characters. I would guess for each input string, we should reduce it to always have only one consecutive SOFT_HYPHEN . |
…tter how many they are. Also extended the test file. Thanks to @syjer to bring these cases up.
|
@syjer You are right, I extended the testcase and the fix to also handle that cases. |
|
Thanks both of you. That would have taken me ages to find. |
danfickle
added a commit
that referenced
this pull request
May 26, 2020
…phen overflowing line. The core problem seems to be the under-reporting of width when we have a soft hyphen that is found to be unbreakable.
danfickle
added a commit
that referenced
this pull request
May 27, 2020
danfickle
added a commit
that referenced
this pull request
Jun 1, 2020
Plus minor behaviour change for word break method to avoid setting ends-on -soft-hyphen flag for soft hyphen at end of box.
danfickle
added a commit
that referenced
this pull request
Jun 7, 2020
This is to make sure infinite loop fixes do not break this functionality.
danfickle
added a commit
that referenced
this pull request
Jun 7, 2020
danfickle
added a commit
that referenced
this pull request
Jun 9, 2020
This should ensure no infinite loop bugs creep in over time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ling.
It demonstrates the bug in #482, a endless loop while trying to break a line. Should be included to detect regressions with that in future.