Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more robust data uri with base64 encoded data. Handle whitespaces. #621

Merged
merged 1 commit into from
Dec 18, 2020
Merged

more robust data uri with base64 encoded data. Handle whitespaces. #621

merged 1 commit into from
Dec 18, 2020

Conversation

syjer
Copy link
Contributor

@syjer syjer commented Dec 17, 2020

This PR allow a more robust handling of base64 encoded data that contains whitespaces.

Chrome&co are able to render them.

I've noticed few issues related to this problem:

@syjer syjer marked this pull request as draft December 17, 2020 15:30
@syjer syjer marked this pull request as ready for review December 17, 2020 15:31
@danfickle
Copy link
Owner

Thanks mate. I like your picture. Resembles me, maybe!

@danfickle danfickle merged commit fcf4a1d into danfickle:open-dev-v1 Dec 18, 2020
@danfickle danfickle mentioned this pull request Dec 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syjer @danfickle