move setting of initPending to false only after initializing the jdk log manager, fix #646 #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… jdk log manager
syjer
changed the title
Without volatile we can have the situation where thread 2 sees the value of initPending to be false and thus doesn't go through the synced section but sees loggers as not yet visible. This was rare and the test only failed on the first run on my machine before always passing. Hopefully, it should always work now. Fingers crossed. NOTE: Both of the changed classes use a version of the "double checked locking" pattern which the internet says requires volatile.
|
Thanks @syjer, I've added a commit with the use of |
|
you are absolutely right about the volatile! Surprising that the test on my pc was not catching this case (maybe increasing the number of concurrent thread?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix the issue as generated by the test case. Not 100% sure it cover all cases.
Fix issue #646 .
To be noted, we may need to cleanup the init part of the logging...