Version 0.6.0 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
daniel-tran
commented
Jun 27, 2022
daniel-tran
commented
- Added text searching functionality into Base Extractor. This supports filtering by text or regular expression.
- Added translation support for: NRSVUE
- As per the search behaviour on Bible Gateway, this is synonymous with the NRSV translation.
- Removed translation support for: CJB
- This translation has some unusual quirks, such as Psalms that start at verse 0. Due to the difficulty of handling these edge cases in a nice way, support is being dropped until there is a specific request to reinstate this translation.
- Added directory for technical experiments.
This translation is synonymous with NRSV
Some Psalms are inconsistently formatted and have various quirks about them, including starting from passage 0 or having secondary passage numbers surrounded by parentheses in the source text. There's also Joel 4 which seems to be exclusively valid for this translation.
To scope out any other translations which also have secondary passage numbers similar to CJB
To keep the year up to date even if the license file isn't updated
Does not include a function to search within a singular passage, as it doesn't seem to provide much value
To showcase potential functionality that might make it into the library in the future, although that is not a guarantee. Also includes helper scripts that can help with debugging and automation.
These functions can handle inputs containing multiple words, which is now better communicated with the new function names
This interface is being added more to keep in line with the primary motivation of this library, despite not adding much value
The easiest resolution is to just let users handle proper state restoration for the singular property in question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.