Report thread-id in response to ?
packet
#105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When more than one thread is active the following warning is visible upon connecting:
This is because gdbstub sends a stop packet of
S05
, which conveys no thread-id. This fix changes the response toT05thread:<tid>;
, which eliminates the warning.API Stability
Checklist
cargo build
compiles withouterrors
orwarnings
cargo clippy
runs withouterrors
orwarnings
cargo fmt
was runValidation
Validated on armv4t and armv4t_multicore
GDB output
armv4t output
Signed-off-by: Ryan Fairfax ryan@thefaxman.net