Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding fails #38

Closed
alappe opened this issue Nov 20, 2018 · 1 comment
Closed

Rounding fails #38

alappe opened this issue Nov 20, 2018 · 1 comment

Comments

@alappe
Copy link

alappe commented Nov 20, 2018

While having different issues, I ran the provided tests and one failed:

$ mix test
................

  1) test SI.number_to_si (Number.SITest)
     test/number/si_test.exs:7
     Assertion with == failed
     code:  assert SI.number_to_si(2.3456e9, base: 1024, unit: "B") == "2.19GB"
     left:  "2.18GB"
     right: "2.19GB"
     stacktrace:
       test/number/si_test.exs:56: (test)

...............................................................

Finished in 0.1 seconds
72 doctests, 8 tests, 1 failure

Randomized with seed 339261

Just wanted to report it…

Erlang/OTP 21 [erts-10.1.1] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [hipe] [dtrace]

Elixir 1.7.4 (compiled with Erlang/OTP 21)
@danielberkompas
Copy link
Owner

Thanks for the issue report! ⭐ ⭐ ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants