Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not updating raw html nodes when using gatsby-plugin-mdx #44

Open
emanueleperuffo opened this issue Sep 10, 2020 · 2 comments
Open

Not updating raw html nodes when using gatsby-plugin-mdx #44

emanueleperuffo opened this issue Sep 10, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@emanueleperuffo
Copy link

I noticed that the following does not work for mdx files in Gatsby

  // Process all HTML images in markdown body
  selectAll('html', markdownAST).forEach((_node: any) => {

Does it make sense to update it to the below?

  // Process all HTML images in markdown body
  selectAll('html, jsx', markdownAST).forEach((_node: any) => {
@danielmahon danielmahon added the enhancement New feature or request label Sep 10, 2020
@danielmahon
Copy link
Owner

let me look into this, should be trivial but I noticed the MDX plugin works slightly different than remark in regards to its lifecycle hooks, have you had any issues with frontmatter conversion using the mdx plugin?

@emanueleperuffo
Copy link
Author

emanueleperuffo commented Sep 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants