Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update support for Redux-Logger 3 #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kevguy
Copy link

@kevguy kevguy commented Apr 18, 2017

First of all, I'm running the code on a Mac and /public/assets/*.js files can't be found when I run webpack-dev-server. So I modified webpack.config.js to fix it.

I'm using version 3 of Redux-Logger, so import logger from 'redux-logger'; will lead to an error saying we should use import { createLogger } from 'redux-logger' instead. So I also made some changes accordingly.

screen shot 2017-04-18 at 6 49 05 pm

Overall all the code are the same. I just made some slight changes to make it work.

@danielstern
Copy link
Owner

Not sure if changing assets to public/assets might break some of the other code?

@kevguy
Copy link
Author

kevguy commented Apr 19, 2017

I don't know, because in every branch when I tried to run webpack-dev-server, I'll get an error saying it couldn't find the bundled js file. At first I would run webpack to produce the js files in the public folder and then modify the src links in every html file to make it work. I found it too exhausting so I decided to modify the webpack config instead. I don't know if this change would break in other machines but at least that's how I made everything work.

On the other hand, I think the change to Redux-Logger is definitely necessary. So how about I split the changes into two pull requests (one for webpack and one for logger) instead?

@danielstern
Copy link
Owner

Sounds good, I'd say that createLogger() does need to be changed, so please split up the PR

@kevguy
Copy link
Author

kevguy commented Apr 21, 2017

I've removed my changes to webpack.config.js and only kept the modified code for Redux-Logger 3.

@kevguy kevguy changed the title fix: fix webpack config and update logger version update support for Redux-Logger 3 Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants