Fixes broken SendGrid binding

[benc-uk]

Description

The SendGrid binding is currently broken, it returns a 400 error and Field:content.0.value Message:The content value must be a string at least one character in length

This is due to a change in data being passed into the binding and the behaviour of strconv.Unquote previously it was quoted and SendGrid didn't like this so I added a call to Unquote when the component was originally written.

However it is now failing as the data is not quoted (some internal change in Dapr, it's been quite some time since I last ran this, maybe Dapr 1.3). It's also possible that strconv.Unquote used to handle unquoted strings more gracefully, but now returns an error

I've left the call to Unquote in there just in case any quotes sneak in there, but this PR adds a fall back to catching any error when unquoting and using the string as is.

Issue reference

Please reference the issue this PR will close: #1866

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

[ItalyPaleAle]

Thanks for your contribution :)

[artursouza]

Is there a chance the issue is from the SDK you are using? Why is this data coming as quoted?

[berndverst]

Is there a chance the issue is from the SDK you are using? Why is this data coming as quoted?

@artursouza that's exactly the problem... whoever authored this was quoting the string, but data should generally not be coming in quotes, which results in this error and hence this PR is necessary.

[benc-uk]

Is there a chance the issue is from the SDK you are using? Why is this data coming as quoted?

@artursouza that's exactly the problem... whoever authored this was quoting the string, but data should generally not be coming in quotes, which results in this error and hence this PR is necessary.

I originally authored this binding, and when I did, the data was definitely quoted (hence me adding Unquote), but this was over 2 years ago, and the way data is passed to bindings in internally by Dapr may have changed in that time

It has nothing to do with any SDK, the field in question is provided by Dapr

[benc-uk]

The "bindings.kafka certification" tests are failing, this seems completely unrelated to my change! 😥

[ItalyPaleAle]

Not sure what happened here, but perhaps while you were fixing DCO you accidentally brought in a lot of commits that changed history. there are now 86 files changed and including reverting changes that are in master already :(

BUT... let's fix it :)

Looks like there's only 1 relevant commit in this PR that needs to be merged: 3a469d7

So here's how you can fix it:

# Make sure you're synced with the upstream repo (ie. dapr/components-contrib)
git fetch upstream
# Reset to the upstream/master branch
git reset --hard upstream/master
# Apply your commit (note the `.patch` at the end)
curl -L "https://github.com/dapr/components-contrib/pull/1867/commits/3a469d71f240e277d34d0aa988604ef7a836854d.patch" | git am
# Now fix the DCO if needed
git commit --amend --no-edit --signoff
# Force-push to your branch
git push --force

This should hopefully fix it

PS: (@berndverst need more reasons to disable squash merging in the bot? ;) )

[codecov]

Codecov Report

Merging #1867 (0c07aa0) into master (5743229) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 0c07aa0 differs from pull request most recent head 982f6aa. Consider uploading reports for the commit 982f6aa to get more accurate results

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
- Coverage   36.81%   36.78%   -0.03%     
==========================================
  Files         181      181              
  Lines       16337    16339       +2     
==========================================
- Hits         6015     6011       -4     
- Misses       9624     9632       +8     
+ Partials      698      696       -2     

Impacted Files	Coverage Δ
bindings/twilio/sendgrid/sendgrid.go	12.64% <0.00%> (-0.30%)	⬇️
state/in-memory/in_memory.go	39.28% <0.00%> (-3.58%)	⬇️
nameresolution/mdns/mdns.go	70.67% <0.00%> (+0.55%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f986b...982f6aa. Read the comment docs.

[benc-uk]

@ItalyPaleAle I'm not sure what happened either! Sorry the branch turned into a mess!! I merged in upstream master to update my branch, the DCO bot started going red again, when you click the 'Details' link there's some instructions in there to do a git reset HEAD~ followed by a rebase.

Anyhow, the reset upstream hard, followed by the patch has fixed it. THANKS!

[DeepanshuA]

Is there a chance the issue is from the SDK you are using? Why is this data coming as quoted?

@artursouza that's exactly the problem... whoever authored this was quoting the string, but data should generally not be coming in quotes, which results in this error and hence this PR is necessary.

I originally authored this binding, and when I did, the data was definitely quoted (hence me adding Unquote), but this was over 2 years ago, and the way data is passed to bindings in internally by Dapr may have changed in that time

It has nothing to do with any SDK, the field in question is provided by Dapr

Thanks for your contribution @benc-uk. Just out of curiosity, can this be due to sendgrid/sendgrid-go#408 ?