Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config api #3606

Merged
merged 19 commits into from
Nov 4, 2021
Merged

feat: add config api #3606

merged 19 commits into from
Nov 4, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Sep 1, 2021

Description

Issue reference

Please reference the issue this PR will close: #2988

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@LaurenceLiZhixin LaurenceLiZhixin changed the title feat: add config api [WIP] feat: add config api Sep 1, 2021
@artursouza artursouza self-assigned this Sep 1, 2021
@yaron2
Copy link
Member

yaron2 commented Sep 8, 2021

@LaurenceLiZhixin notice the checks are failing

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale Issues and PRs without response and removed stale Issues and PRs without response labels Oct 21, 2021
@LaurenceLiZhixin LaurenceLiZhixin changed the title [WIP] feat: add config api feat: add config api Oct 22, 2021
@LaurenceLiZhixin
Copy link
Contributor Author

I updated this pr and It's able to be reviewed I think. @artursouza

cmd/daprd/main.go Outdated Show resolved Hide resolved
dapr/proto/common/v1/common.proto Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
pkg/grpc/api.go Outdated Show resolved Hide resolved
tests/apps/service_invocation_grpc/app.go Outdated Show resolved Hide resolved
pkg/runtime/runtime.go Show resolved Hide resolved
pkg/grpc/api.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #3606 (8e9bcec) into master (97d1e84) will decrease coverage by 0.43%.
The diff coverage is 21.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3606      +/-   ##
==========================================
- Coverage   62.93%   62.49%   -0.44%     
==========================================
  Files         100      101       +1     
  Lines        9421     9525     +104     
==========================================
+ Hits         5929     5953      +24     
- Misses       3026     3107      +81     
+ Partials      466      465       -1     
Impacted Files Coverage Δ
pkg/grpc/api.go 54.03% <0.00%> (-5.11%) ⬇️
pkg/runtime/options.go 11.11% <0.00%> (-1.39%) ⬇️
pkg/runtime/runtime.go 63.98% <20.83%> (-0.98%) ⬇️
pkg/components/configuration/registry.go 100.00% <100.00%> (ø)
pkg/actors/internal/placement.go 89.11% <0.00%> (+1.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97d1e84...8e9bcec. Read the comment docs.

@LaurenceLiZhixin
Copy link
Contributor Author

The tests passed. @artursouza

@daixiang0
Copy link
Member

@LaurenceLiZhixin still fail.

@LaurenceLiZhixin
Copy link
Contributor Author

@LaurenceLiZhixin still fail.

Could you please restart the e2e test again? I guess this problem is not my fault that caused it. And the previous commit can pass all tests.

@daixiang0
Copy link
Member

@LaurenceLiZhixin Please ensure resolve all comments.

@LaurenceLiZhixin
Copy link
Contributor Author

LaurenceLiZhixin commented Nov 2, 2021

@LaurenceLiZhixin Please ensure resolve all comments.

Done @daixiang0

@yaron2
Copy link
Member

yaron2 commented Nov 3, 2021

Thanks @LaurenceLiZhixin resolve conflicts please.

Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaron2 yaron2 merged commit 0ba7933 into dapr:master Nov 4, 2021
@seeflood
Copy link
Member

seeflood commented Nov 4, 2021

Cool!

Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] configuration api design
6 participants