Handled review requests

Signed-off-by: Manuel Menegazzo <manuel.menegazzo@outlook.com>
dapr · Sep 10, 2024 · 4e99586 · 4e99586
1 parent 6b219d2
commit 4e99586
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Dapr.Actors.Generators/ActorClientGenerator.cs b/src/Dapr.Actors.Generators/ActorClientGenerator.cs
@@ -60,7 +60,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
     /// <param name="context">Current generator syntax context passed from generator pipeline.</param>
     /// <param name="cancellationToken">Cancellation token used to interrupt the generation.</param>
     /// <returns>Returns the descriptor of actor client to generate.</returns>
-    static ActorClientDescriptor CreateActorClientDescriptor(
+    private static ActorClientDescriptor CreateActorClientDescriptor(
         GeneratorAttributeSyntaxContext context,
         CancellationToken cancellationToken)
     {
@@ -102,7 +102,7 @@ static ActorClientDescriptor CreateActorClientDescriptor(
     /// <param name="context">Context passed from the source generator when it has registered an output.</param>
     /// <param name="descriptor">Descriptor of actor client to generate.</param>
     /// <exception cref="InvalidOperationException">Throws when one or more required symbols assembly are missing.</exception>
-    static void GenerateActorClientCode(SourceProductionContext context, ActorClientDescriptor descriptor)
+    private static void GenerateActorClientCode(SourceProductionContext context, ActorClientDescriptor descriptor)
     {
         try
         {

diff --git a/src/Dapr.Actors.Generators/Templates.cs b/src/Dapr.Actors.Generators/Templates.cs
@@ -18,7 +18,7 @@ internal static partial class Templates
         /// <exception cref="ArgumentNullException">Throws when destinationNamespace is null.</exception>
         public static SourceText ActorMethodAttributeSourceText(string destinationNamespace)
         {
-            if (destinationNamespace == null)
+            if (destinationNamespace is null)
             {
                 throw new ArgumentNullException(nameof(destinationNamespace));
             }
@@ -54,7 +54,7 @@ internal sealed class {Constants.ActorMethodAttributeTypeName} : Attribute
         /// <exception cref="ArgumentNullException">Throws when destinationNamespace is null.</exception>
         public static SourceText GenerateActorClientAttributeSourceText(string destinationNamespace)
         {
-            if (destinationNamespace == null)
+            if (destinationNamespace is null)
             {
                 throw new ArgumentNullException(nameof(destinationNamespace));
             }