[Workflow] Fix issue with ignored external event payload #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Gillum <cgillum@microsoft.com>
Signed-off-by: Chris Gillum <cgillum@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
=======================================
Coverage 67.22% 67.22%
=======================================
Files 170 170
Lines 5687 5687
Branches 605 605
=======================================
Hits 3823 3823
Misses 1723 1723
Partials 141 141
Flags with carried forward coverage won't be shown. Click here to find out more. |
halspang
reviewed
Jul 5, 2023
|
@cgillum - You have test failures that I think are related to legacy steps in the itests workflow. Can you remove these steps and repush to see if that fixes things? https://github.com/dapr/dotnet-sdk/blob/master/.github/workflows/itests.yml#L108-L116 |
Signed-off-by: Chris Gillum <cgillum@microsoft.com>
halspang
approved these changes
Jul 6, 2023
MonkeyTennis
pushed a commit
to MonkeyTennis/dotnet-sdk
that referenced
this pull request
Jul 14, 2023
* [Workflow] Fix issue with ignored external event payload Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Pushing missing commits Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Remove unnecessary steps from itests.yml Signed-off-by: Chris Gillum <cgillum@microsoft.com> --------- Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Bradley Cotier <bcotier@microsoft.com>
MonkeyTennis
pushed a commit
to MonkeyTennis/dotnet-sdk
that referenced
this pull request
Jul 14, 2023
* [Workflow] Fix issue with ignored external event payload Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Pushing missing commits Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Remove unnecessary steps from itests.yml Signed-off-by: Chris Gillum <cgillum@microsoft.com> --------- Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Bradley Cotier <bcotier@microsoft.com>
MonkeyTennis
pushed a commit
to MonkeyTennis/dotnet-sdk
that referenced
this pull request
Jul 14, 2023
* [Workflow] Fix issue with ignored external event payload Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Pushing missing commits Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Remove unnecessary steps from itests.yml Signed-off-by: Chris Gillum <cgillum@microsoft.com> --------- Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Bradley Cotier <bcotier@microsoft.com>
artursouza
pushed a commit
to artursouza/dotnet-sdk
that referenced
this pull request
Jul 18, 2023
* [Workflow] Fix issue with ignored external event payload Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Pushing missing commits Signed-off-by: Chris Gillum <cgillum@microsoft.com> * Remove unnecessary steps from itests.yml Signed-off-by: Chris Gillum <cgillum@microsoft.com> --------- Signed-off-by: Chris Gillum <cgillum@microsoft.com> Signed-off-by: Artur Souza <asouza.pro@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In dapr/dapr#6614, a user observed that the
RaiseEventAsyncmethod was always resulting in a null payload in the workflow code. This PR fixes the issue, which is isolated to the Dapr Workflow SDK.I also made a couple other small changes as part of this PR:
getInputsAndOutputstotruefor the workflow status query APIs (I decided to do this to improve usability after some frustration while setting up the local repro for the raise event issue)I also updated the Workflow SDK nuget version to
0.3.0.Issue reference
Closes dapr/dapr#6614
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: